fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 23:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Ensure selected options collection is created prior to access

Browse Source
This commit is contained in:
Tim Ledbetter
2025-02-06 11:14:55 +00:00
committed by Tim Flynn
parent dccb374876
commit 8b2de413ae
4 changed files with 111 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View File

@@ -718,7 +718,8 @@ bool HTMLSelectElement::suffering_from_being_missing() const
// If the element has its required attribute specified, and either none of the option elements in the select element's list of options have their selectedness
// set to true, or the only option element in the select element's list of options with its selectedness set to true is the placeholder label option, then the element is suffering from being
// missing.
return has_attribute(HTML::AttributeNames::required) && (m_selected_options->length() == 0 || (m_selected_options->length() == 1 && m_selected_options->item(0) == placeholder_label_option()));
auto selected_options = this->selected_options();
return has_attribute(HTML::AttributeNames::required) && (selected_options->length() == 0 || (selected_options->length() == 1 && selected_options->item(0) == placeholder_label_option()));
}
}

1
Libraries/LibWeb/HTML/HTMLSelectElement.h
View File

@@ -43,6 +43,7 @@ public:
void remove(WebIDL::Long);
GC::Ref<DOM::HTMLCollection> selected_options();
GC::Ref<DOM::HTMLCollection> selected_options() const { return const_cast<HTMLSelectElement*>(this)->selected_options(); }
WebIDL::Long selected_index() const;
void set_selected_index(WebIDL::Long);