fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-25 02:40:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Use the same StringPrototype globally

Browse Source 
To make sure that everyone has the same instance of StringPrototype,
hang a global prototype off of the Interpreter that can be fetched
when constructing new StringObjects.
This commit is contained in:
Andreas Kling
2020-03-15 15:11:13 +01:00
parent 9b4358e150
commit 8dc6416bba
3 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibJS/Interpreter.cpp
View File

@@ -30,6 +30,7 @@
#include <LibJS/Interpreter.h>
#include <LibJS/NativeFunction.h>
#include <LibJS/Object.h>
#include <LibJS/StringPrototype.h>
#include <LibJS/Value.h>
namespace JS {
@@ -38,6 +39,7 @@ Interpreter::Interpreter()
: m_heap(*this)
{
m_global_object = heap().allocate<GlobalObject>();
m_string_prototype = heap().allocate<StringPrototype>();
}
Interpreter::~Interpreter()
@@ -137,6 +139,7 @@ Value Interpreter::get_variable(const String& name)
void Interpreter::collect_roots(Badge<Heap>, HashTable<Cell*>& roots)
{
roots.set(m_global_object);
roots.set(m_string_prototype);
for (auto& scope : m_scope_stack) {
for (auto& it : scope.variables) {