fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 16:45:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibImageDecoderClient: Gracefully recover from decoder crashes :^)

Browse Source 
If the ImageDecoder service crashes while decoding an image for us,
we now recover gracefully and simply return null.

This shields the browser from bugs in our image decoders.
This commit is contained in:
Andreas Kling
2021-02-20 11:33:34 +01:00
parent a446cea759
commit 8fb9d1fd1d
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibImageDecoderClient/Client.cpp
View File

@@ -56,7 +56,12 @@ Optional<DecodedImage> Client::decode_image(const ByteBuffer& encoded_data)
}
memcpy(encoded_buffer.data<void>(), encoded_data.data(), encoded_data.size());
auto response = send_sync<Messages::ImageDecoderServer::DecodeImage>(move(encoded_buffer));
auto response = send_sync_but_allow_failure<Messages::ImageDecoderServer::DecodeImage>(move(encoded_buffer));
if (!response) {
dbgln("ImageDecoder died heroically");
return {};
}
DecodedImage image;
image.is_animated = response->is_animated();