fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibURL: Replace Host's Empty state with making Url's Host optional

Browse Source 
A couple of reasons:
- Origin's Host (when in the tuple state) can't be null
- There's an "empty host" concept in the spec which is NOT the same as a
  null Host, and that was confusing me.
This commit is contained in:
Sam Atkins
2024-11-27 12:48:28 +00:00
committed by Andreas Kling
parent 8b984c0c57
commit 90e763de4c
17 changed files with 44 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/Fetch/Fetching/Fetching.cpp
View File

@@ -322,7 +322,7 @@ WebIDL::ExceptionOr<GC::Ptr<PendingResponse>> main_fetch(JS::Realm& realm, Infra
// - request’s current URL’s scheme is "http"
request->current_url().scheme() == "http"sv
// - request’s current URL’s host is a domain
&& DOMURL::host_is_domain(request->current_url().host())
&& request->current_url().host().has_value() && DOMURL::host_is_domain(request->current_url().host().value())
// FIXME: - Matching request’s current URL’s host per Known HSTS Host Domain Name Matching results in either a
// superdomain match with an asserted includeSubDomains directive or a congruent match (with or without an
// asserted includeSubDomains directive) [HSTS]; or DNS resolution for the request finds a matching HTTPS RR