mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-01-02 06:37:52 +00:00
LibWeb: Avoid dereferencing an empty optional URL
Here, "null" means the empty optional. We don't need to also check if the URL is valid; the url will be null if it was originally invalid.
This commit is contained in:
@@ -427,7 +427,7 @@ String HTMLHyperlinkElementUtils::href() const
|
||||
return String {};
|
||||
|
||||
// 4. Otherwise, if url is null, return this element's href content attribute's value.
|
||||
if (!url->is_valid())
|
||||
if (!url.has_value())
|
||||
return href_content_attribute.release_value();
|
||||
|
||||
// 5. Return url, serialized.
|
||||
|
||||
1
Tests/LibWeb/Text/expected/HTML/href-invalid.txt
Normal file
1
Tests/LibWeb/Text/expected/HTML/href-invalid.txt
Normal file
@@ -0,0 +1 @@
|
||||
href="http://foo:b/c"
|
||||
8
Tests/LibWeb/Text/input/HTML/href-invalid.html
Normal file
8
Tests/LibWeb/Text/input/HTML/href-invalid.html
Normal file
@@ -0,0 +1,8 @@
|
||||
<script src="../include.js"></script>
|
||||
<script>
|
||||
test(() => {
|
||||
const a = document.createElement("a");
|
||||
a.href = "http://foo:b/c";
|
||||
println(`href="${a.href}"`);
|
||||
});
|
||||
</script>
|
||||
Reference in New Issue
Block a user