mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-01-01 14:18:15 +00:00
LibWeb+WebContent: Do not reference-count file request objects
There is currently a memory leak with these file request objects due to the callback on_file_request_finish referencing itself in its capture list. This object does not need to be reference counted or allocated on the heap. It is only ever stored in a HashMap until a response is received from the browser, and it is not shared.
This commit is contained in:
committed by
Linus Groh
parent
9bb469f324
commit
96f409ec1e
@@ -8,8 +8,9 @@
|
||||
|
||||
namespace Web {
|
||||
|
||||
FileRequest::FileRequest(DeprecatedString path)
|
||||
: m_path(move(path))
|
||||
FileRequest::FileRequest(DeprecatedString path, Function<void(ErrorOr<i32>)> on_file_request_finish_callback)
|
||||
: on_file_request_finish(move(on_file_request_finish_callback))
|
||||
, m_path(move(path))
|
||||
{
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user