fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-05 16:14:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse Source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth
2024-11-14 05:50:17 +13:00
committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
326 changed files with 697 additions and 714 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/ResizeObserver/ResizeObserverEntry.cpp
View File

@@ -20,7 +20,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<ResizeObserverEntry>> ResizeObserverEntry::
{
// 1. Let this be a new ResizeObserverEntry.
// 2. Set this.target slot to target.
auto resize_observer_entry = realm.heap().allocate<ResizeObserverEntry>(realm, realm, target);
auto resize_observer_entry = realm.create<ResizeObserverEntry>(realm, target);
// 3. Set this.borderBoxSize slot to result of calculating box size given target and observedBox of "border-box".
auto border_box_size = ResizeObserverSize::calculate_box_size(realm, target, Bindings::ResizeObserverBoxOptions::BorderBox);