mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-29 21:00:06 +00:00
LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>
The main motivation behind this is to remove JS specifics of the Realm from the implementation of the Heap. As a side effect of this change, this is a bit nicer to read than the previous approach, and in my opinion, also makes it a little more clear that this method is specific to a JavaScript Realm.
This commit is contained in:
@@ -16,7 +16,7 @@ JS_DEFINE_ALLOCATOR(VTTCue);
|
||||
WebIDL::ExceptionOr<JS::NonnullGCPtr<VTTCue>> VTTCue::construct_impl(JS::Realm& realm, double start_time, double end_time, String const& text)
|
||||
{
|
||||
// 1. Create a new WebVTT cue. Let cue be that WebVTT cue.
|
||||
auto cue = realm.heap().allocate<VTTCue>(realm, realm, nullptr);
|
||||
auto cue = realm.create<VTTCue>(realm, nullptr);
|
||||
|
||||
// 2. Let cue’s text track cue start time be the value of the startTime argument.
|
||||
cue->m_start_time = start_time;
|
||||
|
||||
Reference in New Issue
Block a user