fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 00:25:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse Source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth
2024-11-14 05:50:17 +13:00
committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
326 changed files with 697 additions and 714 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Services/WebContent/ConnectionFromClient.cpp
View File

@@ -766,7 +766,7 @@ void ConnectionFromClient::create_child_text_node(u64 page_id, Web::UniqueNodeID
return;
}
auto text_node = dom_node->heap().allocate<Web::DOM::Text>(dom_node->realm(), dom_node->document(), "text"_string);
auto text_node = dom_node->realm().create<Web::DOM::Text>(dom_node->document(), "text"_string);
dom_node->append_child(text_node).release_value_but_fixme_should_propagate_errors();
async_did_finish_editing_dom_node(page_id, text_node->unique_id());