fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-04 15:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Actually run UTF-8 decode without BOM

Browse Source 
This fixes a crash using URLSearchParams when provided a percent encoded
string which does not percent decode to valid UTF-8.

Fixes a crash running https://wpt.live/url/urlencoded-parser.any.html
This commit is contained in:
Shannon Booth
2024-08-10 17:56:35 +12:00
committed by Andreas Kling
parent 033ea0e7fb
commit 9c72fc9642
3 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOMURL/URLSearchParams.cpp
View File

@@ -115,8 +115,8 @@ ErrorOr<Vector<QueryParam>> url_decode(StringView input)
auto space_decoded_name = name.replace("+"sv, " "sv, ReplaceMode::All);
// 5. Let nameString and valueString be the result of running UTF-8 decode without BOM on the percent-decoding of name and value, respectively.
auto name_string = TRY(String::from_byte_string(URL::percent_decode(space_decoded_name)));
auto value_string = TRY(String::from_byte_string(URL::percent_decode(value)));
auto name_string = String::from_utf8_with_replacement_character(URL::percent_decode(space_decoded_name));
auto value_string = String::from_utf8_with_replacement_character(URL::percent_decode(value));
TRY(output.try_empend(move(name_string), move(value_string)));
}