fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 16:45:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Update layout before looking at overflow in window.scroll()

Browse Source 
Fixes a crash seen on https://www.ekioh.com/
This commit is contained in:
Andreas Kling
2024-01-18 20:58:53 +01:00
parent 0d8a013ee1
commit 9f6841a65c
3 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/Window.cpp
View File

@@ -1273,6 +1273,12 @@ void Window::scroll(ScrollToOptions const& options)
auto viewport_height = viewport_rect.height();
auto const document = top_level_traversable->active_document();
VERIFY(document);
// Make sure layout is up-to-date before looking at scrollable overflow metrics.
document->update_layout();
VERIFY(document->paintable_box());
auto scrolling_area = document->paintable_box()->scrollable_overflow_rect()->to_type<float>();
// 7. FIXME: For now we always assume overflow direction is rightward