fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 17:28:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Iterate over a copy of associated form controls in form.reset()

Browse Source 
DOM structure may change during reset algorithm invocation, which may
lead to form controls being unregistered.
This commit is contained in:
Andreas Kling
2025-01-21 13:48:16 +01:00
committed by Jelle Raaijmakers
parent 34a8f51eb8
commit a0b44ff5e7
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWeb/HTML/HTMLFormElement.cpp
View File

@@ -317,7 +317,8 @@ void HTMLFormElement::reset_form()
// 2. If reset is true, then invoke the reset algorithm of each resettable element whose form owner is form.
if (reset) {
for (auto element : m_associated_elements) {
GC::RootVector<GC::Ref<HTMLElement>> associated_elements_copy(heap(), m_associated_elements);
for (auto element : associated_elements_copy) {
VERIFY(is<FormAssociatedElement>(*element));
auto& form_associated_element = dynamic_cast<FormAssociatedElement&>(*element);
if (form_associated_element.is_resettable())