fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-08 09:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Rename SharedImageRequest to SharedResourceRequest

Browse Source 
For the SVG <use> element, we want to support loading HTML documents
that have a SVG element inside of it pointed to by the URL fragment.

In this situation we would need to fetch and parse the entire document
in SharedImageRequest (so that we can still cache the SVGs). Rename
SharedImageRequest to SharedResourceRequest to make the class a little
more generic for future usecases.
This commit is contained in:
Shannon Booth
2024-08-03 15:27:08 +12:00
committed by Andreas Kling
parent 2fb5054603
commit a342370dfb
18 changed files with 92 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View File

@@ -47,7 +47,7 @@ void HTMLObjectElement::initialize(JS::Realm& realm)
void HTMLObjectElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_image_request);
visitor.visit(m_resource_request);
}
void HTMLObjectElement::form_associated_element_attribute_changed(FlyString const& name, Optional<String> const&)
@@ -332,8 +332,8 @@ void HTMLObjectElement::load_image()
// NOTE: This currently reloads the image instead of reusing the resource we've already downloaded.
auto data = get_attribute_value(HTML::AttributeNames::data);
auto url = document().parse_url(data);
m_image_request = HTML::SharedImageRequest::get_or_create(realm(), document().page(), url);
m_image_request->add_callbacks(
m_resource_request = HTML::SharedResourceRequest::get_or_create(realm(), document().page(), url);
m_resource_request->add_callbacks(
[this] {
run_object_representation_completed_steps(Representation::Image);
},
@@ -341,10 +341,10 @@ void HTMLObjectElement::load_image()
run_object_representation_fallback_steps();
});
if (m_image_request->needs_fetching()) {
if (m_resource_request->needs_fetching()) {
auto request = HTML::create_potential_CORS_request(vm(), url, Fetch::Infrastructure::Request::Destination::Image, HTML::CORSSettingAttribute::NoCORS);
request->set_client(&document().relevant_settings_object());
m_image_request->fetch_image(realm(), request);
m_resource_request->fetch_resource(realm(), request);
}
}
@@ -372,9 +372,9 @@ i32 HTMLObjectElement::default_tab_index_value() const
JS::GCPtr<DecodedImageData> HTMLObjectElement::image_data() const
{
if (!m_image_request)
if (!m_resource_request)
return nullptr;
return m_image_request->image_data();
return m_resource_request->image_data();
}
bool HTMLObjectElement::is_image_available() const