fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-24 02:09:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibHTML: Ignore completed image loads for already-destroyed <img>'s

Browse Source 
Capture a weak pointer to the element and pass that to the load finish
callback in HTMLImageElement::load_image(). This allows us to ignore
completed loads if the <img> element is no longer around.
This commit is contained in:
Andreas Kling
2019-10-19 09:43:05 +02:00
parent 877ff6bc13
commit a5f3f332ed
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibHTML/DOM/HTMLImageElement.cpp
View File

@@ -23,7 +23,11 @@ void HTMLImageElement::parse_attribute(const String& name, const String& value)
void HTMLImageElement::load_image(const String& src)
{
URL src_url = document().complete_url(src);
ResourceLoader::the().load(src_url, [this](auto data) {
ResourceLoader::the().load(src_url, [this, weak_element = make_weak_ptr()](auto data) {
if (!weak_element) {
dbg() << "HTMLImageElement: Load completed after element destroyed.";
return;
}
if (data.is_null()) {
dbg() << "HTMLImageElement: Failed to load " << this->src();
return;