fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-24 02:09:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Fix percentage insets resolution for grid items

Browse Source 
compute_inset() was incorrectly retrieving the containing block size
because containing_block() is unaware of grid areas that form a
containing block for grid items but do not exist in the layout tree.
With this change, we explicitly pass the containing block into
compute_inset(), allowing it to correctly provide the containing block
sizes for grid items.
This commit is contained in:
Aliaksandr Kalenik
2024-11-11 15:54:21 +01:00
committed by Andreas Kling
parent 07d8ddb5fa
commit a8c1d12e84
9 changed files with 102 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View File

@@ -793,7 +793,8 @@ void BlockFormattingContext::layout_block_level_box(Box const& box, BlockContain
m_margin_state.add_margin(box_state.margin_bottom);
m_margin_state.update_block_waiting_for_final_y_position();
compute_inset(box);
auto const& block_container_state = m_state.get(block_container);
compute_inset(box, content_box_rect(block_container_state).size());
// Now that our children are formatted we place the ListItemBox with the left space we remembered.
if (is<ListItemBox>(box)) {
@@ -1012,7 +1013,8 @@ void BlockFormattingContext::layout_floating_box(Box const& box, BlockContainer
auto& box_state = m_state.get_mutable(box);
auto const& computed_values = box.computed_values();
resolve_vertical_box_model_metrics(box, m_state.get(block_container).content_width());
auto const& block_container_state = m_state.get(block_container);
resolve_vertical_box_model_metrics(box, block_container_state.content_width());
compute_width(box, available_space);
@@ -1166,7 +1168,7 @@ void BlockFormattingContext::layout_floating_box(Box const& box, BlockContainer
if (line_builder)
line_builder->recalculate_available_space();
compute_inset(box);
compute_inset(box, content_box_rect(block_container_state).size());
if (independent_formatting_context)
independent_formatting_context->parent_context_did_dimension_child_root_box();