fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-25 10:48:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

FileSystem: Only retrieve inode metadata once in VFS::chown().

Browse Source
This commit is contained in:
Andreas Kling
2019-06-02 10:31:25 +02:00
parent 1876606973
commit aa35c08633
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Kernel/FileSystem/VirtualFileSystem.cpp
View File

@@ -413,11 +413,13 @@ KResult VFS::chown(StringView path, uid_t a_uid, gid_t a_gid, Custody& base)
if (inode.fs().is_readonly())
return KResult(-EROFS);
if (current->process().euid() != inode.metadata().uid && !current->process().is_superuser())
auto metadata = inode.metadata();
if (current->process().euid() != metadata.uid && !current->process().is_superuser())
return KResult(-EPERM);
uid_t new_uid = inode.metadata().uid;
gid_t new_gid = inode.metadata().gid;
uid_t new_uid = metadata.uid;
gid_t new_gid = metadata.gid;
if (a_uid != (uid_t)-1) {
if (current->process().euid() != a_uid && !current->process().is_superuser())