From ae983a2ef7cfc28dce0c954b308c79ceb25deece Mon Sep 17 00:00:00 2001 From: rmg-x Date: Thu, 4 Jul 2024 14:27:37 -0500 Subject: [PATCH] LibWeb: Add log_filtered_request() method in ResourceLoader This will reduce log noise when visiting sites that have a lot of filtered content. Previously, red error text would be displayed in the logs for each filtered URL. --- Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp b/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp index f454d8affb..7c16f36f11 100644 --- a/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp +++ b/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp @@ -192,6 +192,12 @@ static void log_failure(LoadRequest const& request, ErrorType const& error) dbgln("ResourceLoader: Failed load of: \"{}\", \033[31;1mError: {}\033[0m, Duration: {}ms", url_for_logging, error, load_time_ms); } +static void log_filtered_request(LoadRequest const& request) +{ + auto url_for_logging = sanitized_url_for_logging(request.url()); + dbgln("ResourceLoader: Filtered request to: \"{}\"", url_for_logging); +} + static bool should_block_request(LoadRequest const& request) { auto const& url = request.url(); @@ -211,7 +217,7 @@ static bool should_block_request(LoadRequest const& request) } if (ContentFilter::the().is_filtered(url)) { - log_failure(request, "URL was filtered"sv); + log_filtered_request(request); return true; }