fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 08:36:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Use FileSystem::real_path when comparing paths

Browse Source 
Paths in `headless-browser` tests were being compared by string value.
With this patch, they will be compared by their real path instead,
ensuring relative paths and symlinks are handled correctly.
This commit is contained in:
Jonne Ransijn
2024-11-07 21:57:10 +01:00
committed by Tim Flynn
parent 87dd8714c5
commit b625a92a0b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Ladybird/Headless/Test.cpp
View File

@@ -48,7 +48,7 @@ static ErrorOr<void> load_test_config(StringView test_root_path)
for (auto const& group : config->groups()) {
if (group == "Skipped"sv) {
for (auto& key : config->keys(group))
s_skipped_tests.append(LexicalPath::join(test_root_path, key).string());
s_skipped_tests.append(TRY(FileSystem::real_path(LexicalPath::join(test_root_path, key).string())));
} else {
warnln("Unknown group '{}' in config {}", group, config_path);
}