fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-02-21 15:14:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Fix crash when setting innerHTML inside iframe srcdoc document

Browse Source 
In particular, there was an assertion failure due to the temporary
parser document's "about base URL" being empty when trying to "parse a
URL" during parsing.

We fix this by copying the context element's document's about base URL
to the temporary parsing document while parsing a fragment.

This fixes a crash when loading search results on https://amazon.com/
This commit is contained in:
Andreas Kling
2024-08-28 16:22:44 +02:00
committed by Andreas Kling
parent 782926601d
commit b64df59cc6
3 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Tests/LibWeb/Text/input/HTML/set-innerHTML-inside-iframe-srcdoc-document.html Normal file
View File

@@ -0,0 +1,14 @@
<iframe id="ifr" srcdoc=""></iframe>
<script src="../include.js"></script>
<script>
test(() => {
ifr.contentDocument.body.innerHTML = "<a href='foo.html'>foo</a>";
let href = ifr.contentDocument.body.querySelector("a").href;
if (href.endsWith("foo.html")) {
println("PASS (Didn't crash)");
} else {
println("FAIL");
}
ifr.remove();
});
</script>