fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK+Everywhere: Store JSON strings as String

Browse Source
This commit is contained in:
Timothy Flynn
2025-02-17 13:21:07 -05:00
committed by Tim Flynn
parent e591636419
commit bc54c0cdfb
33 changed files with 163 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Services/WebDriver/Client.cpp
View File

@@ -131,7 +131,7 @@ Web::WebDriver::Response Client::get_status(Web::WebDriver::Parameters, JsonValu
// An implementation-defined string explaining the remote end's readiness state.
JsonObject body;
body.set("ready"sv, readiness_state);
body.set("message"sv, ByteString::formatted("{} to accept a new session", readiness_state ? "Ready"sv : "Not ready"sv));
body.set("message"sv, MUST(String::formatted("{} to accept a new session", readiness_state ? "Ready"sv : "Not ready"sv)));
// 2. Return success with data body.
return JsonValue { body };

2
Services/WebDriver/Session.cpp
View File

@@ -221,7 +221,7 @@ ErrorOr<NonnullRefPtr<Core::LocalServer>> Session::create_server(NonnullRefPtr<S
return;
}
auto window_handle = MUST(String::from_byte_string(maybe_window_handle.value().as_string()));
auto const& window_handle = maybe_window_handle.value().as_string();
web_content_connection->on_close = [this, window_handle]() {
dbgln_if(WEBDRIVER_DEBUG, "Window {} was closed remotely.", window_handle);