fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 07:07:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make <script src> loads partially async (by following the spec)

Browse Source 
Instead of firing up a network request and synchronously blocking for it
to finish via a nested event loop, we now start an asynchronous request
when encountering <script src>.

Once the script load finishes (or fails), it gets executed at one of the
synchronization points in the HTML parser.

This solves some long-standing issues with random unexpected events
getting dispatched in the middle of parsing.
This commit is contained in:
Andreas Kling
2021-09-20 17:06:10 +02:00
parent e11ae33c66
commit c34da16089
3 changed files with 40 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Userland/Libraries/LibWeb/HTML/Parser/HTMLDocumentParser.cpp
View File

@@ -184,8 +184,11 @@ void HTMLDocumentParser::run(const AK::URL& url)
m_stack_of_open_elements.pop();
auto scripts_to_execute_when_parsing_has_finished = m_document->take_scripts_to_execute_when_parsing_has_finished({});
for (auto& script : scripts_to_execute_when_parsing_has_finished) {
// FIXME: Spin the event loop until the script is ready to be parser executed and there's no style sheets blocking scripts.
main_thread_event_loop().spin_until([&] {
return script.is_ready_to_be_parser_executed() && !document().has_a_style_sheet_that_is_blocking_scripts();
});
script.execute_script();
}
@@ -193,12 +196,10 @@ void HTMLDocumentParser::run(const AK::URL& url)
content_loaded_event->set_bubbles(true);
m_document->dispatch_event(content_loaded_event);
// FIXME: The document parser shouldn't execute these, it should just spin the event loop until the list becomes empty.
// FIXME: Once the set has been added, also spin the event loop until the set becomes empty.
auto scripts_to_execute_as_soon_as_possible = m_document->take_scripts_to_execute_as_soon_as_possible({});
for (auto& script : scripts_to_execute_as_soon_as_possible) {
script.execute_script();
}
// 7. Spin the event loop until the set of scripts that will execute as soon as possible and the list of scripts that will execute in order as soon as possible are empty.
main_thread_event_loop().spin_until([&] {
return m_document->scripts_to_execute_as_soon_as_possible().is_empty();
});
// FIXME: Spin the event loop until there is nothing that delays the load event in the Document.