mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-26 11:20:03 +00:00
Bindings: Make item_value return an Optional<JS::Value>
This removes some ambiguity about what the return value should be if the index is out of range. Previously, we would sometimes return a JS null, and other times a JS undefined. It will also let us fold together the checks for whether an index is a supported property index, followed by getting the value just afterwards.
This commit is contained in:
committed by
Andreas Kling
parent
9b59dc5e8b
commit
c5c1a8fcc7
@@ -169,11 +169,11 @@ bool HTMLCollection::is_supported_property_index(u32 index) const
|
||||
return index < length();
|
||||
}
|
||||
|
||||
JS::Value HTMLCollection::item_value(size_t index) const
|
||||
Optional<JS::Value> HTMLCollection::item_value(size_t index) const
|
||||
{
|
||||
auto* element = item(index);
|
||||
if (!element)
|
||||
return JS::js_undefined();
|
||||
return {};
|
||||
return element;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user