mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-25 10:48:41 +00:00
Bindings: Make item_value return an Optional<JS::Value>
This removes some ambiguity about what the return value should be if the index is out of range. Previously, we would sometimes return a JS null, and other times a JS undefined. It will also let us fold together the checks for whether an index is a supported property index, followed by getting the value just afterwards.
This commit is contained in:
committed by
Andreas Kling
parent
9b59dc5e8b
commit
c5c1a8fcc7
@@ -106,11 +106,11 @@ JS::GCPtr<Plugin> PluginArray::named_item(FlyString const& name) const
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
JS::Value PluginArray::item_value(size_t index) const
|
||||
Optional<JS::Value> PluginArray::item_value(size_t index) const
|
||||
{
|
||||
auto return_value = item(index);
|
||||
if (!return_value)
|
||||
return JS::js_null();
|
||||
return {};
|
||||
return return_value.ptr();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user