fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-02-22 23:55:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use GC::Ref<Node> in Range for start/end containers

Browse Source 
Let's propagate the GC'ness of it all to the users of Range.
This commit is contained in:
Jelle Raaijmakers
2024-11-30 10:32:32 +01:00
committed by Andreas Kling
parent bf724ba2f6
commit c87960f8f3
6 changed files with 92 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -2173,7 +2173,7 @@ static String visible_text_in_range(DOM::Range const& range)
if (is<DOM::Text>(*range.start_container()) && range.start_container()->layout_node())
builder.append(static_cast<DOM::Text const&>(*range.start_container()).data().bytes_as_string_view().substring_view(range.start_offset()));
for (DOM::Node const* node = range.start_container(); node != range.end_container()->next_sibling(); node = node->next_in_pre_order()) {
for (GC::Ptr<DOM::Node> node = range.start_container(); node != range.end_container()->next_sibling(); node = node->next_in_pre_order()) {
if (is<DOM::Text>(*node) && range.contains_node(*node) && node->layout_node())
builder.append(static_cast<DOM::Text const&>(*node).data());
}