fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-02-25 17:15:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI: Tweak AbstractButton and subclass constructors

Browse Source 
Taking a "const StringView&" for the initial text does not achieve
anything useful. Just take a "String" and move it into storage.
This commit is contained in:
Andreas Kling
2020-12-28 13:18:10 +01:00
parent 476911e1f9
commit cd9ad6a05e
9 changed files with 25 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Libraries/LibGUI/AbstractButton.cpp
View File

@@ -32,9 +32,10 @@
namespace GUI {
AbstractButton::AbstractButton(const StringView& text)
: m_text(text)
AbstractButton::AbstractButton(String text)
{
set_text(move(text));
set_focus_policy(GUI::FocusPolicy::StrongFocus);
set_background_role(Gfx::ColorRole::Button);
set_foreground_role(Gfx::ColorRole::ButtonText);
@@ -54,11 +55,11 @@ AbstractButton::~AbstractButton()
{
}
void AbstractButton::set_text(const StringView& text)
void AbstractButton::set_text(String text)
{
if (m_text == text)
return;
m_text = text;
m_text = move(text);
update();
}