fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-28 20:29:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Save WebGL context pointer in WebGLObject

Browse Source 
This way we could be sure that context object won't be deallocated
before any of the objects that belong to it.

Having a context pointer is also going to be used in upcoming changes
to generate an INVALID_OPERATION error if an object does not belong to
the context it's being used in.
This commit is contained in:
Aliaksandr Kalenik
2024-12-17 06:15:53 +01:00
committed by Alexander Kalenik
parent b909e3d587
commit cf730870c5
28 changed files with 127 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Libraries/LibWeb/WebGL/WebGLObject.h
View File

@@ -10,6 +10,7 @@
#include <LibWeb/Bindings/PlatformObject.h>
#include <LibWeb/WebGL/Types.h>
#include <LibWeb/WebGL/WebGLRenderingContextBase.h>
namespace Web::WebGL {
@@ -25,16 +26,20 @@ public:
GLuint handle() const { return m_handle; }
protected:
explicit WebGLObject(JS::Realm&, GLuint handle);
explicit WebGLObject(JS::Realm&, WebGLRenderingContextBase&, GLuint handle);
virtual void initialize(JS::Realm&) override;
void initialize(JS::Realm&) override;
void visit_edges(Visitor&) override;
bool invalidated() const { return m_invalidated; }
private:
// FIXME: It should be GC::Ptr instead of raw pointer, but we need to make WebGLRenderingContextBase inherit from PlatformObject first.
WebGLRenderingContextBase* m_context;
GLuint m_handle { 0 };
bool m_invalidated { false };
String m_label;
GLuint m_handle { 0 };
};
}