LibJS: Avoid unnecessary StringImpl copy in StringOrSymbol(String)

2026-01-06 16:45:03 +00:00 · 2020-10-04 17:21:46 +02:00
parent 5de5af60c1
commit cfd141b4f9
1 changed files with 3 additions and 1 deletions
--- a/Libraries/LibJS/Runtime/StringOrSymbol.h
+++ b/Libraries/LibJS/Runtime/StringOrSymbol.h
@@ -51,8 +51,10 @@ public:
    }

    StringOrSymbol(const String& string)
-        : m_ptr(StringImpl::create(string.characters(), string.length()).leak_ref())
+        : m_ptr(string.impl())
    {
+        ASSERT(!string.is_null());
+        static_cast<const StringImpl*>(m_ptr)->ref();
    }

    ~StringOrSymbol()