fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Replace "+" in value with a space while decoding search params

Browse Source
This commit is contained in:
Alisson Lauffer
2024-07-28 16:23:59 -03:00
committed by Andreas Kling
parent 9c72fc9642
commit d38b28b57b
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/URL/search-params-with-plus-in-value.txt Normal file
View File

@@ -0,0 +1,2 @@
key 'key'
value 'value1 value2'

10
Tests/LibWeb/Text/input/URL/search-params-with-plus-in-value.html Normal file
View File

@@ -0,0 +1,10 @@
<script src="../include.js"></script>
<script>
test(() => {
const params = new URLSearchParams('key=value1+value2');
for (const [key, value] of params) {
println(`key '${key}'`);
println(`value '${value}'`);
}
});
</script>

3
Userland/Libraries/LibWeb/DOMURL/URLSearchParams.cpp
View File

@@ -113,10 +113,11 @@ ErrorOr<Vector<QueryParam>> url_decode(StringView input)
// 4. Replace any 0x2B (+) in name and value with 0x20 (SP).
auto space_decoded_name = name.replace("+"sv, " "sv, ReplaceMode::All);
auto space_decoded_value = value.replace("+"sv, " "sv, ReplaceMode::All);
// 5. Let nameString and valueString be the result of running UTF-8 decode without BOM on the percent-decoding of name and value, respectively.
auto name_string = String::from_utf8_with_replacement_character(URL::percent_decode(space_decoded_name));
auto value_string = String::from_utf8_with_replacement_character(URL::percent_decode(value));
auto value_string = String::from_utf8_with_replacement_character(URL::percent_decode(space_decoded_value));
TRY(output.try_empend(move(name_string), move(value_string)));
}