fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-28 12:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Consolidate the attribute change handlers

Browse Source 
We currently have 2 virtual methods to inform DOM::Element subclasses
when an attribute has changed, one of which is spec-compliant. This
patch removes the non-compliant variant.
This commit is contained in:
Timothy Flynn
2024-11-14 08:14:16 -05:00
committed by Andreas Kling
parent c2988a7dd5
commit d4f8b598cb
83 changed files with 224 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/SVG/SVGLinearGradientElement.cpp
View File

@@ -28,9 +28,9 @@ void SVGLinearGradientElement::initialize(JS::Realm& realm)
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGLinearGradientElement);
}
void SVGLinearGradientElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value)
void SVGLinearGradientElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
{
SVGGradientElement::attribute_changed(name, old_value, value);
Base::attribute_changed(name, old_value, value, namespace_);
// FIXME: Should allow for `<number-percentage> | <length>` for x1, x2, y1, y2
if (name == SVG::AttributeNames::x1) {