fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Convert errant MUST to TRY in Temporal.PlainDateTime.with

Browse Source
This commit is contained in:
Timothy Flynn
2025-01-16 08:18:37 -05:00
committed by Andreas Kling
parent c3fc8996bf
commit d5b26183f3
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.cpp
View File

@@ -289,7 +289,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::with)
auto result = TRY(interpret_temporal_date_time_fields(vm, calendar, fields, overflow)); auto result = TRY(interpret_temporal_date_time_fields(vm, calendar, fields, overflow));
// 17. Return ? CreateTemporalDateTime(result, calendar). // 17. Return ? CreateTemporalDateTime(result, calendar).
return MUST(create_temporal_date_time(vm, result, calendar)); return TRY(create_temporal_date_time(vm, result, calendar));
} }
// 5.3.26 Temporal.PlainDateTime.prototype.withPlainTime ( [ plainTimeLike ] ), https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaintime // 5.3.26 Temporal.PlainDateTime.prototype.withPlainTime ( [ plainTimeLike ] ), https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaintime

8
Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.prototype.with.js
View File

@@ -80,4 +80,12 @@ describe("errors", () => {
new Temporal.PlainDateTime(1970, 1, 1).with({ timeZone: {} }); new Temporal.PlainDateTime(1970, 1, 1).with({ timeZone: {} });
}).toThrowWithMessage(TypeError, "Object must be a partial Temporal object"); }).toThrowWithMessage(TypeError, "Object must be a partial Temporal object");
}); });
test("invalid ISO date range", () => {
const plainDateTime = new Temporal.PlainDateTime(-271821, 4, 19, 0, 0, 0, 0, 0, 1);
expect(() => {
plainDateTime.with({ nanosecond: 0 });
}).toThrowWithMessage(RangeError, "Invalid plain date time");
});
}); });