fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Ensure EventHandler visits its mouse selection target

Browse Source 
We hold a raw pointer to the mouse selection target, which is a mixin-
style class inherited only by JS::Cell classes. By not visiting this
object, we sometime had a dangling reference to it after it had been
garbage collected.
This commit is contained in:
Timothy Flynn
2025-02-26 20:40:10 -05:00
committed by Sam Atkins
parent 18a160e0e9
commit d5be18617e
7 changed files with 56 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/UIEvents/gc-mouse-selection-target.txt Normal file
View File

@@ -0,0 +1 @@
PASS (didn't crash)

37
Tests/LibWeb/Text/input/UIEvents/gc-mouse-selection-target.html Normal file
View File

@@ -0,0 +1,37 @@
<!DOCTYPE html>
<iframe id="iframe"></iframe>
<script src="../include.js"></script>
<script>
const runTest = () => {
return new Promise(resolve => {
let iframe = document.getElementById("iframe");
iframe.onload = () => {
internals.movePointerTo(20, 40);
internals.mouseDown(20, 40);
internals.movePointerTo(60, 40);
iframe.onload = () => {
setTimeout(() => {
internals.movePointerTo(20, 40);
resolve();
});
};
iframe.src = "data:text/html,<p contenteditable>Text 2</p>";
};
iframe.src = "data:text/html,<p contenteditable>Text 1</p>";
});
};
asyncTest(async done => {
for (let i = 0; i < 10; ++i) {
await runTest();
internals.gc();
}
println("PASS (didn't crash)");
done();
});
</script>