fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-04 15:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibSQL+Userland: Pass SQL IPC results to clients in a structure

Browse Source 
SQLClient exists as a wrapper around SQL IPC to provide a bit friendlier
interface for clients to deal with. Though right now, it mostly forwards
values as-is from IPC to the clients. This makes it a bit verbose to add
values to IPC responses, as we then have to add it to the callbacks used
by all clients. It's also a bit confusing seeing a sea of "auto" as the
parameter types for these callbacks.

This patch moves these response values to named structures instead. This
will allow adding values without needing to simultaneously update all
clients. We can then separately handle the new values in interested
clients only.
This commit is contained in:
Timothy Flynn
2023-02-03 10:33:10 -05:00
committed by Andreas Kling
parent f0441ee16a
commit d6dee8c0e8
6 changed files with 127 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Userland/DevTools/SQLStudio/MainWidget.cpp
View File

@@ -253,23 +253,23 @@ MainWidget::MainWidget()
};
m_sql_client = SQL::SQLClient::try_create().release_value_but_fixme_should_propagate_errors();
m_sql_client->on_execution_success = [this](auto, auto, auto, auto, auto, auto) {
m_sql_client->on_execution_success = [this](auto) {
read_next_sql_statement_of_editor();
};
m_sql_client->on_execution_error = [this](auto, auto, auto, auto message) {
m_sql_client->on_execution_error = [this](auto result) {
auto* editor = active_editor();
VERIFY(editor);
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Error executing {}\n{}", editor->path(), message));
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Error executing {}\n{}", editor->path(), result.error_message));
};
m_sql_client->on_next_result = [this](auto, auto, auto row) {
m_sql_client->on_next_result = [this](auto result) {
m_results.append({});
m_results.last().ensure_capacity(row.size());
m_results.last().ensure_capacity(result.values.size());
for (auto const& value : row)
for (auto const& value : result.values)
m_results.last().unchecked_append(value.to_deprecated_string());
};
m_sql_client->on_results_exhausted = [this](auto, auto, auto) {
m_sql_client->on_results_exhausted = [this](auto) {
if (m_results.size() == 0)
return;
if (m_results[0].size() == 0)