mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-22 17:28:30 +00:00
AK: Don't implicitly convert Optional<T&> to Optional<T>
C++ will jovially select the implicit conversion operator, even if it's complete bogus, such as for unknown-size types or non-destructible types. Therefore, all such conversions (which incur a copy) must (unfortunately) be explicit so that non-copyable types continue to work. NOTE: We make an exception for trivially copyable types, since they are, well, trivially copyable. Co-authored-by: kleines Filmröllchen <filmroellchen@serenityos.org>
This commit is contained in:
committed by
Ali Mohammad Pur
parent
8468fb9ae5
commit
d7596a0a61
@@ -197,7 +197,7 @@ static auto const& ensure_currency_codes()
|
||||
return currency_codes;
|
||||
}
|
||||
|
||||
Optional<CurrencyCode> get_currency_code(StringView currency)
|
||||
Optional<CurrencyCode const&> get_currency_code(StringView currency)
|
||||
{
|
||||
static auto const& currency_codes = ensure_currency_codes();
|
||||
return currency_codes.get(currency);
|
||||
|
||||
Reference in New Issue
Block a user