fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Keep track of the order in which option elements are selected

Browse Source 
This allows us to locate the most-recently-selected when running the
selectedness update algorithm.
This commit is contained in:
Andreas Kling
2024-11-14 00:05:38 +01:00
committed by Andreas Kling
parent 581597cb34
commit dc9179bb1b
10 changed files with 107 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Libraries/LibWeb/HTML/HTMLOptGroupElement.cpp
View File

@@ -7,6 +7,7 @@
#include <LibWeb/Bindings/HTMLOptGroupElementPrototype.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/HTML/HTMLOptGroupElement.h>
#include <LibWeb/HTML/HTMLSelectElement.h>
namespace Web::HTML {
@@ -25,4 +26,24 @@ void HTMLOptGroupElement::initialize(JS::Realm& realm)
WEB_SET_PROTOTYPE_FOR_INTERFACE(HTMLOptGroupElement);
}
void HTMLOptGroupElement::inserted()
{
Base::inserted();
// AD-HOC: We update the selectedness of our <select> parent here,
// to ensure that the correct <option> is selected after an <optgroup> is dynamically inserted.
if (is<HTMLSelectElement>(*parent()) && first_child_of_type<HTMLOptionElement>())
static_cast<HTMLSelectElement&>(*parent()).update_selectedness();
}
void HTMLOptGroupElement::removed_from(Node* old_parent)
{
Base::removed_from(old_parent);
// The optgroup HTML element removing steps, given removedNode and oldParent, are:
// 1. If oldParent is a select element and removedNode has an option child, then run oldParent's selectedness setting algorithm.
if (old_parent && is<HTMLSelectElement>(*old_parent) && first_child_of_type<HTMLOptionElement>())
static_cast<HTMLSelectElement&>(*old_parent).update_selectedness();
}
}