fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 08:36:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK: Make String::number() infallible

Browse Source 
This API will always succeed in creating a String representing the
provided number in base-10.
This commit is contained in:
Andreas Kling
2024-10-14 10:05:01 +02:00
committed by Andreas Kling
parent 03569fc509
commit dd419b5a8d
46 changed files with 77 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Tests/AK/TestJSON.cpp
View File

@@ -134,11 +134,11 @@ TEST_CASE(json_64_bit_value_coerced_to_32_bit)
auto min = NumericLimits<i64>::min();
auto max = NumericLimits<i64>::max();
auto json = TRY_OR_FAIL(JsonValue::from_string(MUST(String::number(min))));
auto json = TRY_OR_FAIL(JsonValue::from_string(String::number(min)));
EXPECT_EQ(json.get_integer<i64>(), min);
EXPECT(!json.is_integer<i32>());
json = TRY_OR_FAIL(JsonValue::from_string(MUST(String::number(max))));
json = TRY_OR_FAIL(JsonValue::from_string(String::number(max)));
EXPECT_EQ(json.get_integer<i64>(), max);
EXPECT(!json.is_integer<i32>());
}
@@ -146,11 +146,11 @@ TEST_CASE(json_64_bit_value_coerced_to_32_bit)
auto min = NumericLimits<u64>::min();
auto max = NumericLimits<u64>::max();
auto json = TRY_OR_FAIL(JsonValue::from_string(MUST(String::number(min))));
auto json = TRY_OR_FAIL(JsonValue::from_string(String::number(min)));
EXPECT_EQ(json.get_integer<u64>(), min);
EXPECT_EQ(json.get_integer<u32>(), min);
json = TRY_OR_FAIL(JsonValue::from_string(MUST(String::number(max))));
json = TRY_OR_FAIL(JsonValue::from_string(String::number(max)));
EXPECT_EQ(json.get_integer<u64>(), max);
EXPECT(!json.is_integer<u32>());
}