fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-29 21:00:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK: Make String::number() infallible

Browse Source 
This API will always succeed in creating a String representing the
provided number in base-10.
This commit is contained in:
Andreas Kling
2024-10-14 10:05:01 +02:00
committed by Andreas Kling
parent 03569fc509
commit dd419b5a8d
46 changed files with 77 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/StringObject.cpp
View File

@@ -152,14 +152,14 @@ ThrowCompletionOr<MarkedVector<Value>> StringObject::internal_own_property_keys(
// 5. For each integer i starting with 0 such that i < len, in ascending order, do
for (size_t i = 0; i < length; ++i) {
// a. Add ! ToString(𝔽(i)) as the last element of keys.
keys.append(PrimitiveString::create(vm, MUST(String::number(i))));
keys.append(PrimitiveString::create(vm, String::number(i)));
}
// 6. For each own property key P of O such that P is an array index and ! ToIntegerOrInfinity(P) ≥ len, in ascending numeric index order, do
for (auto& entry : indexed_properties()) {
if (entry.index() >= length) {
// a. Add P as the last element of keys.
keys.append(PrimitiveString::create(vm, MUST(String::number(entry.index()))));
keys.append(PrimitiveString::create(vm, String::number(entry.index())));
}
}