fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-04 15:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK: Make String::number() infallible

Browse Source 
This API will always succeed in creating a String representing the
provided number in base-10.
This commit is contained in:
Andreas Kling
2024-10-14 10:05:01 +02:00
committed by Andreas Kling
parent 03569fc509
commit dd419b5a8d
46 changed files with 77 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -1866,7 +1866,7 @@ unsigned HTMLInputElement::size() const
WebIDL::ExceptionOr<void> HTMLInputElement::set_size(unsigned value)
{
return set_attribute(HTML::AttributeNames::size, MUST(String::number(value)));
return set_attribute(HTML::AttributeNames::size, String::number(value));
}
// https://html.spec.whatwg.org/multipage/input.html#concept-input-value-string-number
@@ -1889,11 +1889,11 @@ String HTMLInputElement::convert_number_to_string(double input) const
{
// https://html.spec.whatwg.org/multipage/input.html#number-state-(type=number):concept-input-value-number-string
if (type_state() == TypeAttributeState::Number)
return MUST(String::number(input));
return String::number(input);
// https://html.spec.whatwg.org/multipage/input.html#range-state-(type=range):concept-input-value-number-string
if (type_state() == TypeAttributeState::Range)
return MUST(String::number(input));
return String::number(input);
dbgln("HTMLInputElement::convert_number_to_string() not implemented for input type {}", type());
return {};