fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-01 06:07:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Note what's causing a style invalidation to happen

Browse Source 
You can now build with STYLE_INVALIDATION_DEBUG and get a debug stream
of reasons why style invalidations are happening and where.

I've rewritten this code many times, so instead of throwing it away once
again, I figured we should at least have it behind a flag.
This commit is contained in:
Andreas Kling
2024-09-04 10:01:08 +02:00
committed by Andreas Kling
parent 1f5c49f40d
commit ddbfac38b0
20 changed files with 92 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -156,7 +156,7 @@ void HTMLInputElement::set_checked(bool checked, ChangeSource change_source)
// so we need to invalidate the style of all siblings.
if (parent()) {
parent()->for_each_child([&](auto& child) {
child.invalidate_style();
child.invalidate_style(DOM::StyleInvalidationReason::HTMLInputElementSetChecked);
return IterationDecision::Continue;
});
}
@@ -1142,10 +1142,10 @@ void HTMLInputElement::did_receive_focus()
{
if (!m_text_node)
return;
m_text_node->invalidate_style();
m_text_node->invalidate_style(DOM::StyleInvalidationReason::DidReceiveFocus);
if (m_placeholder_text_node)
m_placeholder_text_node->invalidate_style();
m_placeholder_text_node->invalidate_style(DOM::StyleInvalidationReason::DidReceiveFocus);
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, 0));
}
@@ -1153,10 +1153,10 @@ void HTMLInputElement::did_receive_focus()
void HTMLInputElement::did_lose_focus()
{
if (m_text_node)
m_text_node->invalidate_style();
m_text_node->invalidate_style(DOM::StyleInvalidationReason::DidLoseFocus);
if (m_placeholder_text_node)
m_placeholder_text_node->invalidate_style();
m_placeholder_text_node->invalidate_style(DOM::StyleInvalidationReason::DidLoseFocus);
commit_pending_changes();
}