LibJS: Allow unpaired surrogates in String.prototype.replace

This was resulting in a crash for the WPT test case: https://wpt.live/xhr/send-data-string-invalid-unicode.any.html
2026-01-05 16:14:38 +00:00 · 2024-11-10 22:50:29 +13:00
parent db47cc41f8
commit e02ca0480f
2 changed files with 7 additions and 1 deletions
--- a/Libraries/LibJS/Runtime/AbstractOperations.cpp
+++ b/Libraries/LibJS/Runtime/AbstractOperations.cpp
@@ -1401,7 +1401,7 @@ ThrowCompletionOr<String> get_substitution(VM& vm, Utf16View const& matched, Utf
    }

    // 6. Return result.
-    return MUST(Utf16View { result }.to_utf8());
+    return MUST(Utf16View { result }.to_utf8(Utf16View::AllowInvalidCodeUnits::Yes));
 }

 // 2.1.2 AddDisposableResource ( disposable, V, hint [ , method ] ), https://tc39.es/proposal-explicit-resource-management/#sec-adddisposableresource-disposable-v-hint-disposemethod