fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 17:28:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use [Reflect] to implement HTMLImageElement.decoding

Browse Source 
This ensures the correct behavior when the value of the `decoding`
attribute is changed with `setAttribute()`.
This commit is contained in:
Tim Ledbetter
2024-11-26 18:27:11 +00:00
committed by Tim Ledbetter
parent 0d635100c4
commit e176871fdf
4 changed files with 15 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
Libraries/LibWeb/HTML/HTMLImageElement.cpp
View File

@@ -127,6 +127,11 @@ void HTMLImageElement::form_associated_element_attribute_changed(FlyString const
if (layout_node())
did_update_alt_text(verify_cast<Layout::ImageBox>(*layout_node()));
}
if (name == HTML::AttributeNames::decoding) {
if (value.has_value() && (value->equals_ignoring_ascii_case("sync"sv) || value->equals_ignoring_ascii_case("async"sv)))
dbgln("FIXME: HTMLImageElement.decoding = '{}' is not implemented yet", value->to_ascii_lowercase());
}
}
GC::Ptr<Layout::Node> HTMLImageElement::create_layout_node(CSS::StyleProperties style)
@@ -1171,32 +1176,6 @@ void HTMLImageElement::animate()
paintable()->set_needs_display();
}
StringView HTMLImageElement::decoding() const
{
switch (m_decoding_hint) {
case ImageDecodingHint::Sync:
return "sync"sv;
case ImageDecodingHint::Async:
return "async"sv;
case ImageDecodingHint::Auto:
return "auto"sv;
default:
VERIFY_NOT_REACHED();
}
}
void HTMLImageElement::set_decoding(String decoding)
{
if (decoding == "sync"sv) {
dbgln("FIXME: HTMLImageElement.decoding = 'sync' is not implemented yet");
m_decoding_hint = ImageDecodingHint::Sync;
} else if (decoding == "async"sv) {
dbgln("FIXME: HTMLImageElement.decoding = 'async' is not implemented yet");
m_decoding_hint = ImageDecodingHint::Async;
} else
m_decoding_hint = ImageDecodingHint::Auto;
}
bool HTMLImageElement::allows_auto_sizes() const
{
// An img element allows auto-sizes if: