fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Ensure document.getElementsByName("") returns no elements

Browse Source 
Previously, if a document had any element with a name attribute that
was  set to the empty string, then `document.getElementsByName("")` and
`element.getElementsByName("")` would return a collection including
those elements.
This commit is contained in:
Tim Ledbetter
2024-07-22 21:21:04 +01:00
committed by Andreas Kling
parent 0fceede029
commit e40352b6b5
3 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/DOM/getElementsName-empty-string.txt Normal file
View File

@@ -0,0 +1 @@
document.getElementsByName("").length: 0

8
Tests/LibWeb/Text/input/DOM/getElementsName-empty-string.html Normal file
View File

@@ -0,0 +1,8 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<div name=""></div>
<script>
test(() => {
println(`document.getElementsByName("").length: ${document.getElementsByName("").length}`);
});
</script>

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View File

@@ -464,7 +464,7 @@ void Element::attribute_changed(FlyString const& name, Optional<String> const&,
document().element_id_changed({}, *this); document().element_id_changed({}, *this);
} else if (name == HTML::AttributeNames::name) { } else if (name == HTML::AttributeNames::name) {
if (!value.has_value()) if (value_or_empty.is_empty())
m_name = {}; m_name = {};
else else
m_name = value_or_empty; m_name = value_or_empty;