fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-26 03:09:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/CSS: Check for matching custom properties on parent elements

Browse Source 
Previously, we were only checking the current element and not the
parents in `ResolvedCSSStyleDeclaration::custom_property()` which wasn't
correct.
This commit is contained in:
rmg-x
2024-11-21 16:11:18 -06:00
committed by Andreas Kling
parent 00f6a2b744
commit e4dc758343
3 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp
View File

@@ -604,7 +604,16 @@ Optional<StyleProperty> ResolvedCSSStyleDeclaration::property(PropertyID propert
Optional<StyleProperty> ResolvedCSSStyleDeclaration::custom_property(FlyString const& name) const
{
const_cast<DOM::Document&>(m_element->document()).update_style();
return m_element->custom_properties(m_pseudo_element).get(name);
auto const* element_to_check = m_element.ptr();
while (element_to_check) {
if (auto property = element_to_check->custom_properties(m_pseudo_element).get(name); property.has_value())
return *property;
element_to_check = element_to_check->parent_element();
}
return {};
}
static WebIDL::ExceptionOr<void> cannot_modify_computed_property_error(JS::Realm& realm)