mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-01-06 08:36:15 +00:00
AK: Simplify constructors and conversions from nullptr_t
Problem:
- Many constructors are defined as `{}` rather than using the ` =
default` compiler-provided constructor.
- Some types provide an implicit conversion operator from `nullptr_t`
instead of requiring the caller to default construct. This violates
the C++ Core Guidelines suggestion to declare single-argument
constructors explicit
(https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit).
Solution:
- Change default constructors to use the compiler-provided default
constructor.
- Remove implicit conversion operators from `nullptr_t` and change
usage to enforce type consistency without conversion.
This commit is contained in:
committed by
Andreas Kling
parent
9dc44bf8c4
commit
e6f907a155
@@ -457,7 +457,7 @@ void E1000NetworkAdapter::send_raw(ReadonlyBytes payload)
|
||||
sti();
|
||||
break;
|
||||
}
|
||||
m_wait_queue.wait_on(nullptr, "E1000NetworkAdapter");
|
||||
m_wait_queue.wait_on({}, "E1000NetworkAdapter");
|
||||
}
|
||||
#ifdef E1000_DEBUG
|
||||
dbgln("E1000: Sent packet, status is now {:#02x}!", (u8)descriptor.status);
|
||||
|
||||
Reference in New Issue
Block a user