fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-04 15:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK: Ensure empty StringViews all compare as equal

Browse Source 
Before this change, a StringView with a character-data pointer would
never compare as equal to one with a null pointer, even if they were
both length 0. This could happen for example if one is
default-initialized, and the other is created as a substring.
This commit is contained in:
Sam Atkins
2024-11-15 13:08:15 +00:00
committed by Andreas Kling
parent 87fc7028d7
commit ec5101a1d3
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Tests/AK/TestStringView.cpp
View File

@@ -38,6 +38,13 @@ TEST_CASE(compare_views)
EXPECT_EQ(view1, foo1);
EXPECT_EQ(view1, foo2);
EXPECT_EQ(view1, "foo");
ByteString empty = "";
auto empty_view = view1.substring_view(0, 0);
StringView default_view = {};
EXPECT_EQ(empty.view(), ""sv);
EXPECT_EQ(empty_view, ""sv);
EXPECT_EQ(default_view, ""sv);
}
TEST_CASE(conforms_to_iterator_protocol)