mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-22 09:19:03 +00:00
LibWeb: Forbid reentrancy of style-layout-repaint in EventLoop::process
Fixes crashing on https://playbiolab.com/ in VERIFY(page.client().is_ready_to_paint()) caused by attempting to start the next repaint before the ongoing repaint is done.
This commit is contained in:
committed by
Andreas Kling
parent
5faca4f027
commit
f341af1d72
@@ -177,6 +177,17 @@ void EventLoop::process()
|
||||
// 8. Microtasks: Perform a microtask checkpoint.
|
||||
perform_a_microtask_checkpoint();
|
||||
|
||||
if (m_is_running_reflow_steps) {
|
||||
// NOTE: If we entered style-layout-repaint steps, then we need to wait for them to finish before doing next iteration.
|
||||
schedule();
|
||||
return;
|
||||
}
|
||||
|
||||
m_is_running_reflow_steps = true;
|
||||
ScopeGuard const guard = [this] {
|
||||
m_is_running_reflow_steps = false;
|
||||
};
|
||||
|
||||
// 9. Let hasARenderingOpportunity be false.
|
||||
[[maybe_unused]] bool has_a_rendering_opportunity = false;
|
||||
|
||||
|
||||
@@ -113,6 +113,8 @@ private:
|
||||
bool m_execution_paused { false };
|
||||
|
||||
bool m_skip_event_loop_processing_steps { false };
|
||||
|
||||
bool m_is_running_reflow_steps { false };
|
||||
};
|
||||
|
||||
EventLoop& main_thread_event_loop();
|
||||
|
||||
Reference in New Issue
Block a user