fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Removed unused is_fixed_position flag from PushStackingContext

Browse Source 
This flag is no longer needed after we switched to using scroll frames
to account for fixed position.
This commit is contained in:
Aliaksandr Kalenik
2024-09-28 18:41:38 +02:00
committed by Andreas Kling
parent 061ad33705
commit f377bf862a
3 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/Painting/Command.h
View File

@@ -112,7 +112,6 @@ struct StackingContextMask {
struct PushStackingContext { struct PushStackingContext {
float opacity; float opacity;
bool is_fixed_position;
// The bounding box of the source paintable (pre-transform). // The bounding box of the source paintable (pre-transform).
Gfx::IntRect source_paintable_rect; Gfx::IntRect source_paintable_rect;
// A translation to be applied after the stacking context has been transformed. // A translation to be applied after the stacking context has been transformed.

4
Userland/Libraries/LibWeb/Painting/DisplayListPlayerSkia.cpp
View File

@@ -493,10 +493,6 @@ void DisplayListPlayerSkia::push_stacking_context(PushStackingContext const& com
canvas.clipShader(builder.makeShader()); canvas.clipShader(builder.makeShader());
} }
if (command.is_fixed_position) {
// FIXME: Resetting matrix is not correct when element is nested in a transformed stacking context
canvas.resetMatrix();
}
canvas.concat(matrix); canvas.concat(matrix);
} }

1
Userland/Libraries/LibWeb/Painting/DisplayListRecorder.cpp
View File

@@ -297,7 +297,6 @@ void DisplayListRecorder::push_stacking_context(PushStackingContextParams params
{ {
append(PushStackingContext { append(PushStackingContext {
.opacity = params.opacity, .opacity = params.opacity,
.is_fixed_position = params.is_fixed_position,
.source_paintable_rect = params.source_paintable_rect, .source_paintable_rect = params.source_paintable_rect,
// No translations apply to fixed-position stacking contexts. // No translations apply to fixed-position stacking contexts.
.post_transform_translation = params.is_fixed_position .post_transform_translation = params.is_fixed_position