fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 15:16:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Fix spec bug in "destroy child navigable"

Browse Source 
See for more details:
https://github.com/whatwg/html/issues/10242

Before this change it only worked because of another bug in
`EventLoop::spin_processing_tasks_with_source_until()`
where we execute tasks regardless of whether they are runnable or not.
This commit is contained in:
Aliaksandr Kalenik
2024-04-02 17:10:35 +02:00
committed by Andreas Kling
parent facece1a2a
commit f66d33423b
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp
View File

@@ -259,17 +259,23 @@ void NavigableContainer::destroy_the_child_navigable()
if (!navigable)
return;
// 3. Set container's content navigable to null.
m_content_navigable = nullptr;
// Not in the spec:
// Setting container's content navigable makes document *not* be "fully active".
// Therefore, it is moved to run in afterAllDestruction callback of "destroy a document and its descendants"
// when all queued tasks are done.
// "Has been destroyed" flag is used instead to check whether navigable is already destroyed.
if (navigable->has_been_destroyed())
return;
navigable->set_has_been_destroyed();
HTML::all_navigables().remove(navigable);
// FIXME: 4. Inform the navigation API about child navigable destruction given navigable.
// 5. Destroy a document and its descendants given navigable's active document.
navigable->active_document()->destroy_a_document_and_its_descendants({});
// Not in the spec
navigable->set_has_been_destroyed();
HTML::all_navigables().remove(navigable);
navigable->active_document()->destroy_a_document_and_its_descendants([this] {
// 3. Set container's content navigable to null.
m_content_navigable = nullptr;
});
// 6. Let parentDocState be container's node navigable's active session history entry's document state.
auto parent_doc_state = this->navigable()->active_session_history_entry()->document_state();