fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-28 12:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "LibWeb: Fix endless spinning in apply_the_history_step()"

Browse Source 
This reverts commit 609a72f7c7.
This commit is contained in:
Andreas Kling
2024-03-30 08:28:16 +01:00
parent 872fa58ef8
commit f90489acd6
3 changed files with 13 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/navigation/remove-iframe-from-timeout-callback.txt
View File

@@ -1 +1 @@
PASS: did not crash

26
Tests/LibWeb/Text/input/navigation/remove-iframe-from-timeout-callback.html
View File

@@ -1,16 +1,12 @@
<script src="../include.js"></script><div id="foo"><iframe></iframe><script> <script src="../include.js"></script>
setTimeout(function () { <div id="foo">
foo.remove(); <iframe></iframe>
window.done = true; <script>
}, 0); setTimeout(function () {
</script></div><iframe></iframe><script> foo.remove();
asyncTest(function (done) { // Pass (didn't crash)
let internalId; internals.signalTextTestIsDone();
internalId = setInterval(function () {
if (window.done) {
clearInterval(internalId);
done();
}
}, 0); }, 0);
}); </script>
</script>PASS: did not crash </div>
<iframe></iframe>

2
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View File

@@ -572,7 +572,7 @@ TraversableNavigable::HistoryStepResult TraversableNavigable::apply_the_history_
// AD-HOC: Since currently populate_session_history_entry_document does not run in parallel // AD-HOC: Since currently populate_session_history_entry_document does not run in parallel
// we call spin_until to interrupt execution of this function and let document population // we call spin_until to interrupt execution of this function and let document population
// to complete. // to complete.
main_thread_event_loop().spin_until([&] { main_thread_event_loop().spin_processing_tasks_with_source_until(Task::Source::NavigationAndTraversal, [&] {
return !changing_navigable_continuations.is_empty() || completed_change_jobs == total_change_jobs; return !changing_navigable_continuations.is_empty() || completed_change_jobs == total_change_jobs;
}); });