fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibTLS: Remove unreachable buffer length check

Browse Source 
Refer to the while condition
This commit is contained in:
Pavel Shliak
2024-12-20 02:37:45 +04:00
committed by Andreas Kling
parent 811d5a5c3e
commit fa02d94d30
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibTLS/Handshake.cpp
View File

@@ -257,8 +257,6 @@ ssize_t TLSv12::handle_handshake_payload(ReadonlyBytes vbuffer)
auto original_length = buffer_length; auto original_length = buffer_length;
while (buffer_length >= 4 && !m_context.critical_error) { while (buffer_length >= 4 && !m_context.critical_error) {
ssize_t payload_res = 0; ssize_t payload_res = 0;
if (buffer_length < 1)
return (i8)Error::NeedMoreData;
auto type = static_cast<HandshakeType>(buffer[0]); auto type = static_cast<HandshakeType>(buffer[0]);
auto write_packets { WritePacketStage::Initial }; auto write_packets { WritePacketStage::Initial };
size_t payload_size = buffer[1] * 0x10000 + buffer[2] * 0x100 + buffer[3] + 3; size_t payload_size = buffer[1] * 0x10000 + buffer[2] * 0x100 + buffer[3] + 3;