fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-27 03:37:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK+Everywhere: Convert JSON value serialization to String

Browse Source 
This removes the use of StringBuilder::OutputType (which was ByteString,
and only used by the JSON classes). And it removes the StringBuilder
template parameter from the serialization methods; this was only ever
used with StringBuilder, so a template is pretty overkill here.
This commit is contained in:
Timothy Flynn
2025-02-17 15:08:17 -05:00
committed by Tim Flynn
parent 2c03de60da
commit fe2dff4944
15 changed files with 98 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibDevTools/Connection.cpp
View File

@@ -7,7 +7,6 @@
#include <AK/Debug.h>
#include <AK/JsonObject.h>
#include <AK/JsonValue.h>
#include <AK/StringBuilder.h>
#include <LibCore/EventLoop.h>
#include <LibDevTools/Connection.h>
@@ -34,7 +33,7 @@ Connection::~Connection() = default;
// https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#packets
void Connection::send_message(JsonValue const& message)
{
auto serialized = message.serialized<StringBuilder>();
auto serialized = message.serialized();
if constexpr (DEVTOOLS_DEBUG) {
if (message.is_object() && message.as_object().get("error"sv).has_value())
@@ -43,7 +42,7 @@ void Connection::send_message(JsonValue const& message)
dbgln("\x1b[1;32m<<\x1b[0m {}", serialized);
}
if (m_socket->write_formatted("{}:{}", serialized.length(), serialized).is_error()) {
if (m_socket->write_formatted("{}:{}", serialized.byte_count(), serialized).is_error()) {
if (on_connection_closed)
on_connection_closed();
}